From: Masaki Kanno <kanno.masaki@jp.fujitsu.com>
Subject: [PATCH] Fix error message for xm trigger command
Date: Tue, 04 Sep 2007 15:08:24 +0900
Message-ID: <ADC7EEBA00BA23kanno.masaki@jp.fujitsu.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="Boundary-1hfF5vCeTa6vxmVIUJWHf"
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

--Boundary-1hfF5vCeTa6vxmVIUJWHf
Content-Type: text/plain; charset=iso-2022-jp
Content-Transfer-Encoding: 7bit
Content-Description: Mail message body

Hi,

When I tested xm trigger command with a wrong argument, I saw the 
following error message. 

 # xm trigger vm1 xyz
 Error: __init__() takes exactly 2 arguments (3 given)
 Usage: xm trigger <Domain> <nmi|reset|init> [<VCPU>]
 
 Send a trigger to a domain.

This patch fixes the error message as follows. 

 # xm trigger vm1 xyz
 Error: Invalid trigger: xyz
 Usage: xm trigger <Domain> <nmi|reset|init> [<VCPU>]
 
 Send a trigger to a domain.

BTW:
 The type of "TRIGGER_TYPE" is dictionary.  domain_send_trigger() 
 refers to the keys of "TRIGGER_TYPE" without using keys() currently. 
 This patch adds keys() there. 


Signed-off-by: Masaki Kanno <kanno.masaki@jp.fujitsu.com>

Best regards,
 Kan


--Boundary-1hfF5vCeTa6vxmVIUJWHf
Content-Type: application/octet-stream; name="xm_trigger.patch"
Content-Disposition: attachment; filename="xm_trigger.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtciAyNTYxNjBmZjE5YjcgdG9vbHMvcHl0aG9uL3hlbi94ZW5kL1hlbmREb21haW4u
cHkKLS0tIGEvdG9vbHMvcHl0aG9uL3hlbi94ZW5kL1hlbmREb21haW4ucHkJVGh1IEF1ZyAx
NiAxMzoyNzo1OSAyMDA3ICswMTAwCisrKyBiL3Rvb2xzL3B5dGhvbi94ZW4veGVuZC9YZW5k
RG9tYWluLnB5CU1vbiBTZXAgMDMgMjI6MjA6NTIgMjAwNyArMDkwMApAQCAtMTU5NCwxMCAr
MTU5NCwxMCBAQCBjbGFzcyBYZW5kRG9tYWluOgogICAgICAgICAgICAgcmFpc2UgVk1CYWRT
dGF0ZSgiRG9tYWluICclcycgaXMgbm90IHN0YXJ0ZWQiICUgZG9taWQsCiAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIFBPV0VSX1NUQVRFX05BTUVTW0RPTV9TVEFURV9SVU5OSU5H
XSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUE9XRVJfU1RBVEVfTkFNRVNbZG9t
aW5mby5fc3RhdGVHZXQoKV0pCi0gICAgICAgIGlmIHRyaWdnZXJfbmFtZS5sb3dlcigpIGlu
IFRSSUdHRVJfVFlQRTogCisgICAgICAgIGlmIHRyaWdnZXJfbmFtZS5sb3dlcigpIGluIFRS
SUdHRVJfVFlQRS5rZXlzKCk6IAogICAgICAgICAgICAgdHJpZ2dlciA9IFRSSUdHRVJfVFlQ
RVt0cmlnZ2VyX25hbWUubG93ZXIoKV0KICAgICAgICAgZWxzZToKLSAgICAgICAgICAgIHJh
aXNlIFhlbmRFcnJvcigiSW52YWxpZCB0cmlnZ2VyOiAlcyIsIHRyaWdnZXJfbmFtZSkKKyAg
ICAgICAgICAgIHJhaXNlIFhlbmRFcnJvcigiSW52YWxpZCB0cmlnZ2VyOiAlcyIgJSB0cmln
Z2VyX25hbWUpCiAgICAgICAgIHRyeToKICAgICAgICAgICAgIHJldHVybiB4Yy5kb21haW5f
c2VuZF90cmlnZ2VyKGRvbWluZm8uZ2V0RG9taWQoKSwKICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHRyaWdnZXIsCg==

--Boundary-1hfF5vCeTa6vxmVIUJWHf
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--Boundary-1hfF5vCeTa6vxmVIUJWHf--