From: Adriaan de Jong Date: Fri, 10 Dec 2010 09:40:41 +0100 Message-ID: References: <20101210062512.17827.qmail@...1287...> <4D01DD1C.5010506@...1114...> <20101210081613.3086.qmail@...1287...> In-Reply-To: <20101210081613.3086.qmail@...1287...> Content-Language: en-US MIME-Version: 1.0 Subject: Re: [Openvpn-devel] [Patch] OpenVPN PolarSSL Support Preview [7/8] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: Peter Stuge , "openvpn-devel@lists.sourceforge.net" > Adriaan de Jong wrote: > > > > About the whitespace: it's a tad difficult to split the patches > > > > now. Are you sure it wouldn't be acceptable this way? > > Peter Stuge wrote: > I may have misunderstood this. (I read "now" as "this late", but I > guess maybe you meant "this early".) > You read it correctly, but let's retroactively change that to this early :) > I'd use git for the patches right away anyway, but that doesn't > matter. My point about whitespace was not that it is a critical > issue at this point, but something I think should be cleaned before > inclusion. git would make it trivial to do (this early) so I think > it's a good idea. >=20 I'm afraid that we started off development based on checked out sources (qu= ite a long time ago). I'll start rebasing to git as soon as I've heard that= the git tree is stable. > I'm afraid I'm unable to review the patches in greater depth. :\ Thanks for your feedback though, I'm not that familiar with autoconf's inte= rnals. Adriaan