From: Tom Yan Date: Mon, 6 Jan 2020 08:48:00 +0000 Message-ID: References: <20200106080426.40701-1-list@...1798...> In-Reply-To: <20200106080426.40701-1-list@...1798...> Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BN7PR04MB5251B27BE1C62779CA7B4876FD3C0BN7PR04MB5251namp_" MIME-Version: 1.0 Subject: Re: [Openvpn-devel] [PATCH 1/1] configure.ac: replace set with env List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: OpenVPN Development , Christian Hesse Cc: Christian Hesse --_000_BN7PR04MB5251B27BE1C62779CA7B4876FD3C0BN7PR04MB5251namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable How about printenv (without grep)? ________________________________ From: Christian Hesse Sent: Monday, January 6, 2020 4:04:26 PM To: OpenVPN Development Cc: Christian Hesse Subject: [Openvpn-devel] [PATCH 1/1] configure.ac: replace set with env From: Christian Hesse The shell builtin `set` produces different output for different shells: bash$ set | grep '^TERM=3D' TERM=3Dxterm dash$ set | grep '^TERM=3D' TERM=3D'xterm' This may break reproducible builds depending on what shell is used. Let's replace `set` with `env`, which is a real command and always produces identical output. Signed-off-by: Christian Hesse --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index a47e0a06..f13ff7b6 100644 --- a/configure.ac +++ b/configure.ac @@ -1326,7 +1326,7 @@ if test "${enable_async_push}" =3D "yes"; then ) fi -CONFIGURE_DEFINES=3D"`set | grep '^enable_.*=3D' ; set | grep '^with_.*=3D= '`" +CONFIGURE_DEFINES=3D"`env | grep '^enable_.*=3D' ; env | grep '^with_.*=3D= '`" AC_DEFINE_UNQUOTED([CONFIGURE_DEFINES], ["`echo ${CONFIGURE_DEFINES}`"], [= Configuration settings]) TAP_WIN_COMPONENT_ID=3D"PRODUCT_TAP_WIN_COMPONENT_ID" _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel --_000_BN7PR04MB5251B27BE1C62779CA7B4876FD3C0BN7PR04MB5251namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
How about printenv (without grep)?

From: Christian Hesse <= ;list@...1798...>
Sent: Monday, January 6, 2020 4:04:26 PM
To: OpenVPN Development <openvpn-devel@lists.sourceforge.net><= br> Cc: Christian Hesse <mail@...1798...>
Subject: [Openvpn-devel] [PATCH 1/1] configure.ac: replace set with = env
 
From: Christian Hesse <mail@...1798...>

The shell builtin `set` produces different output for different shells:

bash$ set | grep '^TERM=3D'
TERM=3Dxterm
dash$ set | grep '^TERM=3D'
TERM=3D'xterm'

This may break reproducible builds depending on what shell is used.

Let's replace `set` with `env`, which is a real command and always
produces identical output.

Signed-off-by: Christian Hesse <mail@...1798...>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index a47e0a06..f13ff7b6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1326,7 +1326,7 @@ if test "${enable_async_push}" =3D &quo= t;yes"; then
         )
 fi
 
-CONFIGURE_DEFINES=3D"`set | grep '^enable_.*=3D' ; set | grep '^with_= .*=3D'`"
+CONFIGURE_DEFINES=3D"`env | grep '^enable_.*=3D' ; env | grep '^w= ith_.*=3D'`"
 AC_DEFINE_UNQUOTED([CONFIGURE_DEFINES], ["`echo ${CONFIGURE_DEFI= NES}`"], [Configuration settings])
 
 TAP_WIN_COMPONENT_ID=3D"PRODUCT_TAP_WIN_COMPONENT_ID"


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
http= s://lists.sourceforge.net/lists/listinfo/openvpn-devel
--_000_BN7PR04MB5251B27BE1C62779CA7B4876FD3C0BN7PR04MB5251namp_--