From: Keir Fraser Subject: Re: [PATCH] compile fix for RING_HAS_UNCONSUMED_REQUESTS Date: Tue, 17 Oct 2006 19:02:35 +0100 Message-ID: References: <20061017132953.GA7307@totally.trollied.org> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20061017132953.GA7307@totally.trollied.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: John Levon , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 17/10/06 14:29, "John Levon" wrote: > # HG changeset patch > # User john.levon@sun.com > # Date 1161091691 25200 > # Node ID ae762c159e7311a5a19e6b29227a665994a1325b > # Parent a58e7e6dde6b1f6094ea07917b3db794082c409b > fixes to compile ring.h on solaris with Sun's cc > > Signed-off-by: Mark Johnson I like the gcc syntax so I'll take the patch version of that macro as a non-GNUC alternative, so both live in the upstream header file. I'm not taking the chunk with the mb/wmb definitions for Solaris. It's up to the user of this public header file to provide suitable definitions external to this header file. -- Keir