From: Keir Fraser Subject: Re: [PATCH] Avoid triggering the softlockup BUG when offline for too long. Date: Mon, 27 Nov 2006 18:54:26 +0000 Message-ID: References: <5d6222a80611270847y5e05b994sa9bce57819a3eea5@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5d6222a80611270847y5e05b994sa9bce57819a3eea5@mail.gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Glauber de Oliveira Costa , Glauber de Oliveira Costa Cc: xen-devel@lists.xensource.com, Keir Fraser List-Id: xen-devel@lists.xenproject.org On 27/11/06 4:47 pm, "Glauber de Oliveira Costa" wrote: >> * stolen time, as well as blocked time, does not have it's corresponding >> per processor variable updated all in once, but in multiples of >> NS_PER_TICK chuncks. If we're out for too long, we could detect stolen >> being too great multiple times, leading to far more calls to the >> softlockup watchdog then we want too. > > FYI, I just made a simple test checking for stolen time instead of > offline, and it's in fact called way too oftenly. That doesn't make sense. Processed_stolen_time should lag at most 1 jiffy behind actual stolen time. So you still need to accumulate at least 10*HZ-1 jiffies of stolen time in one go to end up touching the softlockup watchdog. As far as I can see, anyway. What workload did you run to test using stolen time? -- Keir