From: Keir Fraser Subject: Re: [PATCH] Enable uppercase letters to be entered in QEMU monitor terminal Date: Wed, 29 Nov 2006 12:19:40 +0000 Message-ID: References: <20061129120429.GB10275@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20061129120429.GB10275@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Daniel P. Berrange" , Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 29/11/06 12:04, "Daniel P. Berrange" wrote: >> Doesn't this eat the shift/caps key events even when not in qemu monitor >> mode? What if the guest has shortcut key combos involving those keys, for >> example? > > Opps, yes, the shift/caps bits need to be protected by a conditional on > !is_graphics_console(). Will redo the patch to fix that. Tracking shift/caps at all times makes sense, but the cooking-and-eating should happen conditionally. -- Keir