From: Keir Fraser Subject: Re: [PATCH] Allow mini-os to unbind all evtchns Date: Wed, 29 Nov 2006 12:25:37 +0000 Message-ID: References: <66C4E3ED-B00A-4A1E-8077-00C6C8A8748C@cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <66C4E3ED-B00A-4A1E-8077-00C6C8A8748C@cam.ac.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Grzegorz Milos , Jacob Gorm Hansen Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On 29/11/06 12:16, "Grzegorz Milos" wrote: > The patch looks good to me. I only have one comment: it would be good > to have unbind_all_ports in the events header file. It looked bogus to me. What if event channels are bound/unbound/bound multiple times during the mini-os lifetime (can't happen right now, but maybe in future). The port array will overflow. Perhaps it should be a bitmap instead (set on bind; clear on unbind)? -- Keir