From: Keir Fraser Subject: Re: [PATCH] non-flat protected mode HVM support Date: Wed, 29 Nov 2006 15:38:22 +0000 Message-ID: References: <456DB30C.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <456DB30C.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , Trolle Selander Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 29/11/06 15:19, "Jan Beulich" wrote: > Indeed, I didn't look outside the hvm directories. But it's not just the > instruction > fetching there, there are other segment based operations in there, too. Hence > I think adding a callback to obtain the base address would be cleaner; > hvm_get_segment_base() could be used in the hvm case, and a simple function > should be put in place for pv guest handling (for those, assuming a zero base > address seems reasonably safe at this point, since the behavior of them is > known, and if ever page table updates get done through segments with non- > zero base addresses this would need to be revisited. > > I'll try to take care of this unless you beat me. I have a big patch outstanding on the x86_emulate code to simplify the interface and properly support page-straddling data operands and non-zero segment bases. -- Keir