From: Keir Fraser Subject: Re: [PATCH] add canonical address checks to HVM Date: Thu, 30 Nov 2006 17:55:55 +0000 Message-ID: References: <456DAFBE.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <456DAFBE.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 29/11/06 15:05, "Jan Beulich" wrote: > Add proper long mode canonical address checks to PIO emulation and MSR > writes, the former paralleling the limit checks added for 32-bit guests. > Also catches two more cases in the MSR handling code where only ECX > (rather than RCX) should be used. > > Signed-off-by: Jan Beulich I wonder if we would be better consistently *removing* the canonical-address checks? It's not a security issue after all -- the check is done in hardware only to prevent code from ever depending on being able to use the high address bits for software flags. I think it is harmless to deviate from native behaviour on this issue and makes our emulation code smaller and simpler. -- Keir