From: Keir Fraser Subject: Re: [PATCH] add canonical address checks to HVM Date: Fri, 01 Dec 2006 08:07:02 +0000 Message-ID: References: <456FF03E.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <456FF03E.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 1/12/06 8:05 am, "Jan Beulich" wrote: > I think it might be a security issue: > - In MSR writes, are you certain there's not going to be any problem now or > in the future when the state gets actually loaded into CPU registers? > - In memory accesses, at least until no failures to read/write guest memory > are being ignored anymore. We should be defensive about guest reads/writes/MSR-accesses anyway. I.e., we should at least accept faults on those accesses, and make sure the worst that happens is a domain crash. -- Keir