From: Keir Fraser Subject: Re: [PATCH] add canonical address checks to HVM Date: Fri, 01 Dec 2006 09:16:17 +0000 Message-ID: References: <456FF3CC.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <456FF3CC.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 1/12/06 08:20, "Jan Beulich" wrote: >> We should be defensive about guest reads/writes/MSR-accesses anyway. I.e., >> we should at least accept faults on those accesses, and make sure the worst >> that happens is a domain crash. > > That I take for granted. But it's far from optimal. I don't know about modern > Windows (has been too long since I was last looking at their handling of > this), > but at least Linux takes precautions when doing potentially dangerous > accesses in so many places that it would seem unreasonable to crash a > domain when it could be passed a simple fault at the right point, and let it > decide for itself whether it wants to die. Linux would never be barking mad enough to poke a non-canonical address in 64-bit mode, I'm sure. :-) But yes, I will take a closer look at the patch... -- Keir