From: Keir Fraser Subject: Re: [RFC][PATCH] 1/3] [XEN] Use explicit bit sized fieldsfor exported xentrace data. Date: Thu, 07 Dec 2006 10:32:41 +0000 Message-ID: References: <8A87A9A84C201449A0C56B728ACF491E04EDD5@liverpoolst.ad.cl.cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <8A87A9A84C201449A0C56B728ACF491E04EDD5@liverpoolst.ad.cl.cam.ac.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Pratt , George Dunlap , Mark Williamson Cc: xen-devel@lists.xensource.com, Keir Fraser , Tony Breeds List-Id: xen-devel@lists.xenproject.org On 6/12/06 16:10, "Ian Pratt" wrote: > The ultimate best way of doing it would be to have trace functions that > took a format string and a variable number of arguments. The actual > trace record written in the buffer would just contain the record type > and the length of the record, followed by the variable data. The format > string would be written out in an a separate segment, enabling it to be > extracted and used by the trace post-process tool to pretty print the > records. I agree this is a good way to go. We certainly don't want lots of little single use trace-record structures, one per trace point in Xen! That would be overkill -- format strings are a good middle ground. -- Keir