From: Keir Fraser Subject: Re: [PATCH] Add a --force option to detach operations Date: Thu, 14 Dec 2006 10:04:58 +0000 Message-ID: References: <20061213223552.GB22520@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20061213223552.GB22520@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Glauber de Oliveira Costa , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 13/12/06 22:35, "Glauber de Oliveira Costa" wrote: > The following patch adds a --force option to detach operations. It > avoids the device being held forever when frontend fails. Looks good. I think --force should be more brutal (i.e., assume that we have already politely requested the disconnection, if that's what we really wanted). Apart from that, we should remember that if we need to use --force then it probably indicates a problem in the frontend driver. If you can repro a situation that requires --force then we should investigate that (and work out a patch for blkfront). Thanks, Keir