From: Keir Fraser Subject: Re: [PATCH] fix multicall state tracking Date: Thu, 14 Dec 2006 10:36:16 +0000 Message-ID: References: <457EBD07.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <457EBD07.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 12/12/06 13:30, "Jan Beulich" wrote: > This replaces the previous fix to multicall state tracking so that now the > multicall- > in-progress status is maintained on a per-VCPU basis (all other state remains > per physical CPU). This seems cleaner than the previous hack requiring > clearing > of the flags in domain_crash_synchronous(). > > Signed-off-by: Jan Beulich I decided to entirely move away from domain_crash_synchronous() in hypercall context. So the code in domain_crash_synchronous() is just a warning for errant code -- later it can become BUG_ON(). This means that multicall state can remain per-cpu, unless per-vcpu seems much better (personally I think it doesn't really matter either way so we may as well stick with what we have). -- Keir