From: Keir Fraser Subject: Re: [PATCH] Re: Re: [PATCH 2/2] PV framebuffer Date: Thu, 14 Dec 2006 11:30:13 +0000 Message-ID: References: <200612141059.kBEAxGeO013542@fjmscan502.ms.jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200612141059.kBEAxGeO013542@fjmscan502.ms.jp.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Atsushi SAKAI , Markus Armbruster Cc: xen-devel@lists.xensource.com, xen-ia64-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 14/12/06 10:58, "Atsushi SAKAI" wrote: > I searched the code and found > the code in smp_call_function line337@linux/arch/ia64/kernel/smp.c > WARN_ON(irqs_disabled()); > > The call trace problem caused by spin_lock_irqsave() > in xenfb_update_screen@linux/drivers/xen/fbfront/xenfb.c > > Why you need to use spin_lock_irqsave in xenfb_update()? > I understand the locking but why irqsave is required at this point? The lock is used in fb_ops, vm_ops and kthread contexts. None of these are executed in IRQ context so irqsave is not needed. I'll remove it. I'm not sure whether you can call zap_page_range() even with a spinlock held though... -- Keir