From: Keir Fraser Subject: Re: [RFC] Re: [PATCH] fix xenctl_cpumap translation to handle bitops accessed like arrays Date: Wed, 17 Jan 2007 13:55:39 +0000 Message-ID: References: <95B80CFB-BE47-450C-978C-D0A396F1D1B2@watson.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <95B80CFB-BE47-450C-978C-D0A396F1D1B2@watson.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jimi Xenidis Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 17/1/07 12:50, "Jimi Xenidis" wrote: >> Actually, your >> 'no-op' long_to_byte_bitmap() implementation does not memcpy -- why >> is that? > > This is a little (possibly dirty) attempt to avoid a copy if no > conversion is required. > As long as the caller uses the return value all is well. > I'd happy to make it a memcpy() and feel better about it. Yes please. K.