From: Keir Fraser Subject: Re: Re: [patch 12/21] Xen-paravirt: Allocate and free vmalloc areas Date: Fri, 16 Feb 2007 19:06:58 +0000 Message-ID: References: <45D5E98B.4070904@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <45D5E98B.4070904@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge , Keir Fraser Cc: Zachary Amsden , xen-devel@lists.xensource.com, virtualization@lists.osdl.org, linux-kernel@vger.kernel.org, Jan Beulich , Chris Wright , Ian Pratt , Andrew Morton , Christian Limpach , Andi Kleen List-Id: xen-devel@lists.xenproject.org On 16/2/07 17:27, "Jeremy Fitzhardinge" wrote: > In fact that file is only built for i386 and x86_64, so there really is no >> problem with using vmalloc_sync_all() directly and without ifdef. >> > > I had moved it to mm/vmalloc.c in response to previous review comments > (namely, its not Xen specific, so it shouldn't live in the Xen part of > the tree). Then the call will have to be CONFIG_X86. I hadn't realised powerpc were also using lock_vm_area. However I suspect that the x86 issue that those functions were written doesn't even exist on powerpc, or any other non-x86 architecture. I guess we should change the name of alloc_vm_area, by the way. Perhaps alloc_vm_area_sync() or similar, to give some hint of what it's doing and how it differs from other vmalloc-area functions? -- Keir