From: Keir Fraser Subject: Re: [PATCH] linux/x86: Advertise which page table entries contain MFNs Date: Tue, 20 Feb 2007 09:52:08 +0000 Message-ID: References: <45D1E3F7.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <45D1E3F7.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 13/2/07 15:14, "Jan Beulich" wrote: > .. and hence need to be (un)canonicalized during save/restore. > > The patch should apply without the page table handling adjustment one, yet > the values passed in the new note assume that patch to be applied. > > Signed-off-by: Jan Beulich Could we just define _PAGE_PRESENT in the header file (it's not likely to change!) rather than have to mess up another couple of header files to allow inclusion in assembly files. I see the need to change the ELFNOTE macro, but is the vararg macro syntax ever unavailable when building Linux? Do you have to keep the old ELFNOTE definition hanging around? Why are the extra build rules required, which kill EXTRA_AFLAGS? Has it something to do with trying to cleanly include pgtable.h? I think I agree with the change to NEXT_PAGE() but the change belongs upstream, not in our patches. -- Keir