From: Keir Fraser Subject: Re: [PATCH] [XEN] [ACM] Simplify the event channel scanning Date: Tue, 27 Feb 2007 19:02:36 +0000 Message-ID: References: <1172596799.31444.2.camel@941e-2.watson.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1172596799.31444.2.camel@941e-2.watson.ibm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Stefan Berger , xen-devel List-Id: xen-devel@lists.xenproject.org On 27/2/07 17:19, "Stefan Berger" wrote: > This patch simplifies the scanning of a domain's event channels > considering that an 'ECS_UNBOUND' event channel is not connected and can > be skipped. > > Signed-off-by: Stefan Berger This code is still broken: you are checking only the first event-channel in each bucket. You need a double loop: the new inner loop should iterate from 0 to EVTCHNS_PER_BUCKET-1. ports = d->evtchn[bucket]; If ( ports == NULL ) break; for ( j = 0; j < EVTCHNS_PER_BUCKET; j++ ) .... process ports[j] .... -- Keir