From: Keir Fraser Subject: Re: [PATCH] x86: allow NMI injection Date: Wed, 28 Feb 2007 13:15:58 +0000 Message-ID: References: <45E581EF.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <45E581EF.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 28/2/07 12:21, "Jan Beulich" wrote: >> Notably this patch changes the way that a NMI handler is registered to use >> the native-like vector 2. This changes the guest interface though. Do you > > But only in a benign fashion - registering the old way is still possible, > registering through set_trap_table now works where it previously didn't. > >> really need to be able to specify a custom CS? Can you not vector to the >> flat CS and then far jump? > > I probably could, but I'm generally opposed to making assumptions about > the guest where this is unnecessary (i.e. I dislike all callback pointers > registered without selectors). Oh I see. That sounds reasonable. vcpu_op() isn't perhaps a great match but then neither is physdev_op() really. I'll have a think about which is better. -- Keir