From: Keir Fraser <keir@xensource.com>
Subject: Re: [PATCH] pciback: check function return values
Date: Wed, 28 Mar 2007 14:41:01 +0100
Message-ID: <C2302EFD.C619%keir@xensource.com>
References: <460A7D47.76E4.0078.0@novell.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <460A7D47.76E4.0078.0@novell.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <jbeulich@novell.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org




On 28/3/07 13:35, "Jan Beulich" <jbeulich@novell.com> wrote:

> .. of functions declared with __must_check post-2.6.18.
> 
> (As a note - I'm getting the impression that when used as a module, pciback
> appears to have a number of memory leaks).
> 
> Signed-off-by: Jan Beulich <jbeulich@novell.com>

Where is the mystery pciback_exit() function defined? You use it but don't
provide an implementation.

 -- Keir