From: Keir Fraser <keir@xensource.com>
Subject: Re: [PATCH] linux: simplify and perform checking of
	multicall status
Date: Thu, 05 Apr 2007 10:15:23 +0100
Message-ID: <C23A7CBB.CCFB%keir@xensource.com>
References: <4614D6B2.76E4.0078.0@novell.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4614D6B2.76E4.0078.0@novell.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <jbeulich@novell.com>, Keir Fraser <keir@xensource.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org




On 5/4/07 10:00, "Jan Beulich" <jbeulich@novell.com> wrote:

> Huh, indeed. And perhaps it should (give the rest of the function) even
> be
> 
> if (unlikely(rc < 0))
> return rc;
> BUG_ON(rc);
> 
> (i.e. so that positive return values indicate the failed slot, negative ones
> indicate a failure of the multicall itself).

Makes sense. I'll merge that in.

 -- Keir