From: Keir Fraser Subject: Re: [PATCH] 32on64 vCPU cleanup fix Date: Thu, 26 Apr 2007 18:36:50 +0100 Message-ID: References: <4630E786.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4630E786.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 26/4/07 16:55, "Jan Beulich" wrote: > Since vcpu_destroy_pagetables() clears v->arch.guest_table for hvm vCPUs, > it must be avoided to free the page with MFN zero. Up to yesterday there was never a case that we'd have an HVM vcpu with IS_COMPAT()==1 (although there was some code that tried to handle this case). Now that we support this there's a general need for a cleanup so that code that is compat-mode-dependent explicitly checks for PV vs. HVM if that matters to it. I've applied an initial general fix as c/s 14961:f18e1ca6. I think everything else is okay, but I'm not 100% sure about shadow code (although that was one place that was explicitly checking for PV 32bit guests where it cared, so I hope it's okay). Please take a look and make sure I'm not very confused about what's going on. :-) -- Keir