From: Keir Fraser <keir@xensource.com>
Subject: Re: [PATCH]: Fix mem= kernel parameter
Date: Tue, 22 May 2007 17:17:24 +0100
Message-ID: <C278D624.F5BC%keir@xensource.com>
References: <4652FD76.1010600@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4652FD76.1010600@redhat.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Chris Lalancette <clalance@redhat.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org


We used to support this properly but it must have got dropped during some
kernel upgrade. Thanks for adding it back in.

 -- Keir

On 22/5/07 15:25, "Chris Lalancette" <clalance@redhat.com> wrote:

> The third case is the one that is currently broken.   Looking at the code
> above,
> you can see that the array allocated for the p2m table is too small in that
> case, and during the subsequent memcpy() can cause a page fault and then an
> OOPs.  The attached patch handles the third case by decreasing the
> reservation,
> and only copying the appropriate number of entries into the p2m table.