From: Keir Fraser <keir@xensource.com>
Subject: Re: [PATCH] calling zap_low_mappings breaks xen boot on
	the es7000
Date: Thu, 24 May 2007 10:04:53 +0100
Message-ID: <C27B13C5.F6DB%keir@xensource.com>
References: <94C8C9E8B25F564F95185BDA64AB05F60513EAC9@USTR-EXCH5.na.uis.unisys.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <94C8C9E8B25F564F95185BDA64AB05F60513EAC9@USTR-EXCH5.na.uis.unisys.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Subrahmanian, Raj" <raj.subrahmanian@unisys.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 23/5/07 22:16, "Subrahmanian, Raj" <raj.subrahmanian@unisys.com> wrote:

>> Either we should just delay the zap_low_mappings() call, or
>> fix your code to map_domain_page()/unmap_domain_page(). How
>> late in boot do you need the low mappings?
> 
> This patch delays the zap_low_mappings() call until after the
> smp_prepare_cpus call. With this patch, I am able to run Xen on the
> ES7000 and a Dell SC 1430.

So where is the late low-memory access happening? There's not that much
es7000-specific code. It can't be hard to fix properly. If the physical
pointer is known to be below 1MB you can just __va() it. If not you may need
to use a fixmap, or acpi_map_table, or just __va() only on x86_64. I'd like
to keep the zap as early as possible to catch truly erroneous low pointers.

 -- Keir