From: Becky Bruce Date: Tue, 3 Feb 2009 13:35:39 -0600 Subject: [U-Boot] [PATCH 1/2] flash/cfi_flash: Use virtual sector start address, not phys In-Reply-To: References: <1233614092-5480-1-git-send-email-beckyb@kernel.crashing.org> <498805F8.4000803@vastech.co.za> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Feb 3, 2009, at 8:48 AM, Kumar Gala wrote: > > On Feb 3, 2009, at 2:53 AM, Pieter wrote: > >>> >>> static inline void flash_unmap(flash_info_t *info, flash_sect_t >>> sect, >>> unsigned int offset, void *addr) >>> { >>> - unsigned int byte_offset = offset * info->portwidth; >>> - >>> - unmap_physmem(addr, flash_sector_size(info, sect) - byte_offset); >>> } >> >> >> Since "flash_unmap(flash_info_t *info, flash_sect_t sect,unsigned >> int offset, void *addr)" function is empty after applying the >> patch, should all function calls in the /drivers/mtd/cfi_flash.c >> file not also be removed? >> >> cheers pieter > > I think its best to leave them alone for now. If in the future we > really think flash_unmap isn't going to get called we can remove > them. Stefan? > I left those in case there might later be something that needs to be done there, so that flash_map/unmap remain symmetric. But I can remove them if Stefan wants. Cheers, B