From: Keir Fraser Subject: Re: [PATCH] Fix races in iret hypercall Date: Thu, 09 Aug 2007 09:44:41 +0100 Message-ID: References: <200708091035.08282.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200708091035.08282.Christoph.Egger@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christoph Egger , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 9/8/07 09:35, "Christoph Egger" wrote: > Attached patch fixes races seen on SMP when multiple HVM guests > execute the iret instruction at the same time. > > current vcpu can change in the middle of do_iret(). This is fine as a cleanup, but it does not fix any bugs! For two reasons: 1. Current vcpu *cannot* change in the middle of do_iret(). Xen does not support involuntary preemption. 2. HVM guests do not ever execute do_iret(). That function is for pv guests only. How did you conclude there was a bug? -- Keir