From: Keir Fraser Subject: Re: [amd iommu] [patch 2/2]Add APCI tables support for AMD IOMMU Date: Thu, 28 Feb 2008 21:21:40 +0000 Message-ID: References: <200802281910.17157.mark.williamson@cl.cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200802281910.17157.mark.williamson@cl.cam.ac.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Mark Williamson Cc: Wei Wang2 , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 28/2/08 19:10, "Mark Williamson" wrote: >> To be honest I didn't look all that closely at these patches, beyond >> observing that they largely modify AMD-IOMMU-specific files. It would be >> nice to fix up the coding style -- I tend to do this myself only when I >> already have the offending files loaded into an Emacs buffer for some other >> reason. > > ok. > > FWIW, my checker tree has a Xen coding style checker plus a writeup of some > key points of the coding style as a document. Would you take a patch to add > these to the tree for future contributors to refer to? I'd certainly strongly consider it. -- Keir