From: Keir Fraser Subject: Re: [PATCH] linux/balloon: don't allow ballooning down a domain below a reasonable limit Date: Sat, 05 Apr 2008 22:39:38 +0100 Message-ID: References: <47F6604E.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <47F6604E.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , xen-devel@lists.xensource.com Cc: Ky Srinivasan , Kurt Garloff List-Id: xen-devel@lists.xenproject.org On 4/4/08 16:07, "Jan Beulich" wrote: > +#ifndef CONFIG_XEN > +#define max_pfn totalram_pages > +#endif This is silly. We modify totalram_pages as we balloon up and down, so this really isn't very max_pfn-like after ballooning gets under way. So I've applied the patch but I made it a no-op if !defined(CONFIG_XEN), until/unless someone comes up with a better alternative to totalram_pages. Possibly just latching totalram_pages when we install the balloon driver would be sufficient? -- Keir