From: Keir Fraser Subject: Re: [PATCH] Fix arguments passed to SHADOW_PRINTK Date: Thu, 11 Sep 2008 12:00:50 +0100 Message-ID: References: <48C8F673.4070503@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <48C8F673.4070503@lab.ntt.co.jp> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Yoshiaki Tamura , xen-devel Cc: Satoshi Moriai List-Id: xen-devel@lists.xenproject.org On 11/9/08 11:44, "Yoshiaki Tamura" wrote: > When I compiled xen-3.3-testing with DEBUG_TRACE_DUMP in xen/include/xen/lib.h > turned on, I got some errors at SHADOW_PRINTK. > The following patch will fix the arguments passed to SHADOW_PRINTK in > xen/arch/x86/mm/shadow/common.c and xen/arch/x86/mm/shadow/multi.c. > > Although I haven't tested, it is the same for xen-unstable.hg First chunks of patch: If there is no longer a va to print, then don't manufacture one to print; just remove it entirely from the printk. Apart from anything else, using sh_map_domain_page() without sh_unmap_domain_page() will leak mappings. And the va printed will not be useful anyway. Final chunk of patch: print regs->eip? That should work on both x86_64 and i386. Please fix and re-send. Thanks, Keir