From: Keir Fraser Subject: Re: [PATCH] fix misc issues related to allowingsupport of more CPUs Date: Mon, 22 Sep 2008 09:35:21 +0100 Message-ID: References: <48D76979.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <48D76979.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 22/9/08 08:46, "Jan Beulich" wrote: >> Why must it be WARN_ON()? You think you could specify strings so long that >> they overflow 32 bits? You've got other problems in that case. > > No, that's not the reason. It's because of how bitmap_scnprintf() and > bitmap_scnlistprintf() work - they can (validly, assuming that the code > having been derived from Linux and still being that way in Linux, hence > apparently considered correct) pass negative sizes to scnprintf(), and > hence it must not kill the system to actually do so. The obvious answer would be to fix the bogus callers. Or consider negative size to be a valid input. Warning on what callers consider valid behaviour is just weird. I would say the former (fix the callers) is the better way to go here; presumably they just need to clamp the size parameter. -- Keir