From: Keir Fraser Subject: Re: [PATCH] x86: fix domain cleanup Date: Tue, 28 Oct 2008 10:49:33 +0000 Message-ID: References: <4906F986.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4906F986.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 28/10/08 10:37, "Jan Beulich" wrote: > __put_page_type() is already a complex function actually, so let's define a >> __put_final_page_type() containing a call to free_page_type() plus the >> current tail of free_page_type(). __put_page_type() can call that; >> relinquish memory can call free_page_type() directly. > > Will do it that way for submission. In testing it with that code inlined in > __put_page_type(), I can confirm that this closes the memory leak, but > it (obviously) doesn't address the crash when encountering a PGT_partial > page hanging off of a page table being cleaned up by that explicit call > to free_page_type() getting executed as a side effect of > DOMAIN_DESTRUCT_AVOID_RECURSION. The question of course really > is whether it's worthwhile trying to fix that, or rather to do away with it > altogether by utilizing the 'real' preemption. I don't actually understand the AVOID_RECURSION logic in relinquish_memory(). I'd be delighted to get rid of it. -- Keir