From: Keir Fraser Subject: Re: [PATCH] x86: fix domain cleanup Date: Tue, 28 Oct 2008 13:03:46 +0000 Message-ID: References: <490717D9.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <490717D9.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 28/10/08 12:47, "Jan Beulich" wrote: > If we set the simple rule of "Whoever sets PGT_partial must make sure > he leaves an extra ref pending, and whoever clears PGT_partial must drop > that reference", we should be fine in my opinion. Hmmm... you could be right. It sounds better than what we have just now at least. :-) -- Keir > Also, a preempted get_page_and_type_from_pagenr() drops the general > reference, and a preempted put_page_and_type() retains it, so to me > the page state seems to be consistent between the two.