From: Keir Fraser Subject: Re: [PATCH] ioemu: Get guest uuid from xenstore Date: Mon, 19 Jan 2009 18:16:30 +0000 Message-ID: References: <18804.49176.534448.448249@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <18804.49176.534448.448249@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson , Yosuke Iwamatsu Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 19/01/2009 18:02, "Ian Jackson" wrote: > I don't think this patch is safe. /local/domain//vm is > owned by (and thus writeable by) the domain in question. We need a > trustworthy copy of this information. Perhaps worth checking with a xenstore-ls -p, or a xenstore-write attempt within a domU, but the vm node should be owned by dom0 and read-only by the domU. The recent xenstore permissions fixes should ensure that. So the patch should be safe and if it's not it's a xend bug that needs fixing. -- Keir