From: Keir Fraser Subject: Re: [PATCH 1 of 3] fix S3 suspend error Date: Mon, 23 Feb 2009 05:45:28 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Tian, Kevin" , "Lu, Guanqun" , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 23/02/2009 05:15, "Keir Fraser" wrote: >> Xen owns a few devices with most as system class, so for >> simplicity interrupt is disabled from start. It's not worthy of touching >> this flow for this simple spinlock issue, imo. :-) > > Can you point out any core devices in modern Linux 2.6 which implement the > suspend_late() or *_noirq() callbacks (those appear to be the ones handled > in device_power_down() with IRQs disabled)? They seem very obsolete/legacy, > and looks to me like we could unconditionally *not* disable IRQs rather than > unconditionally disabling them. Oh, yes, now I see the sysdev_suspend() stuff. Okay, I agree with the patches then. -- Keir