From: Keir Fraser Subject: Re: [PATCH] xen: mask XSAVE in cpuid since we don't allow guests to use it Date: Sun, 08 Mar 2009 09:13:16 +0000 Message-ID: References: <49B35829.1010403@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <49B35829.1010403@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge Cc: Boris Derzhavets , Xen-devel , "Marc - A. Dahlhaus [ Administration | Westermann GmbH ]" List-Id: xen-devel@lists.xenproject.org On 08/03/2009 05:31, "Jeremy Fitzhardinge" wrote: > Mask X86_FEATURE_XSAVE in cpuid leaf 1, ecx, as we don't allow guests to > use it (by setting cr4.OSXSAVE). > > This prevents crashes in pvops dom0 kernels, as new versions of Linux try > to use this feature. > > (This patch deals with dom0 cpuid; I'm not sure where the right place to > set up the default mask for domU is.) Thanks, the whole problem stems from blacklisting rather than whitelisting feature bits. I might try and do a more comprehensive job for xen-unstable at least. This is good for 3.3. -- Keir