From: Keir Fraser Subject: Re: [PATCH] use atomic_t type for system wide credit scheduler statistics Date: Mon, 09 Mar 2009 08:36:06 +0000 Message-ID: References: <49B4D3AF.7050705@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <49B4D3AF.7050705@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Yang, Xiaowei" Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 09/03/2009 08:30, "Yang, Xiaowei" wrote: > Keir Fraser wrote: >> Not while csched stats are enabled by default. They get cranked all over the >> place. How much does this race matter? We probably just lose a few >> increments? > > Yes. The higher frequency the count is updated, the more increments lost > can we see - comparing to atomic version, counts like "vcpu_check" and > "scheduele" lose increments very obviously due to race. The best thing to do would be to move the stats into perfc_defn.h, don't you think? The CSCHED_* macro wrappers could be kept but wrap the existing common mechanism for perf counters. -- Keir