From: Keir Fraser Subject: Re: [PATCH] fs-backend: fix compile problems Date: Wed, 18 Mar 2009 15:00:15 +0000 Message-ID: References: <413918.19320.qm@web56108.mail.re3.yahoo.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1040865828==" Return-path: In-Reply-To: <413918.19320.qm@web56108.mail.re3.yahoo.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "bderzhavets@yahoo.com" , Stefano Stabellini Cc: xen-devel List-Id: xen-devel@lists.xenproject.org > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --===============1040865828== Content-type: multipart/alternative; boundary="B_3320233216_9787708" > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --B_3320233216_9787708 Content-type: text/plain; charset="ISO-8859-1" Content-transfer-encoding: quoted-printable Upgrade to latest xen-unstable. It=B9s fixed there. -- Keir On 18/03/2009 14:53, "Boris Derzhavets" wrote: > Now "make install-xen" fails :- >=20 > make[6]: Entering directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu/mc= heck' > gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g > -fno-strict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-val= ue > -Wdeclaration-after-statement -nostdinc -fno-builtin -fno-common -iwithp= refix > include -Werror -Wno-pointer-arith -pipe > -I/usr/src/xen-unstable.hg/xen/include > -I/usr/src/xen-unstable.hg/xen/include/asm-x86/mach-generic > -I/usr/src/xen-unstable.hg/xen/include/asm-x86/mach-default -msoft-float > -fno-stack-protector -mno-red-zone -fpic -fno-reorder-blocks > -fno-asynchronous-unwind-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -g -D__XEN= __ > -DVERBOSE -fno-omit-frame-pointer -DCONFIG_FRAME_POINTER -MMD -MF > .mce_intel.o.d -c mce_intel.c -o mce_intel.o > mce_intel.c:17: error: static declaration of =8Cfirstbank=B9 follows non-stat= ic > declaration > x86_mca.h:95: error: previous declaration of =8Cfirstbank=B9 was here > make[6]: *** [mce_intel.o] Error 1 > make[6]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu/mch= eck' > make[5]: *** [mcheck/built_in.o] Error 2 > make[5]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu' > make[4]: *** [cpu/built_in.o] Error 2 > make[4]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86' > make[3]: *** [/usr/src/xen-unstable.hg/xen/arch/x86/built_in.o] Error 2 > make[3]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86' > make[2]: *** [/usr/src/xen-unstable.hg/xen/xen] Error 2 > make[2]: Leaving directory `/usr/src/xen-unstable.hg/xen' > make[1]: *** [install] Error 2 > make[1]: Leaving directory `/usr/src/xen-unstable.hg/xen' > make: *** [install-xen] Error 2 >=20 >=20 > --- On Wed, 3/18/09, Boris Derzhavets wrote: >> From: Boris Derzhavets >> Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems >> To: "Stefano Stabellini" >> Cc: "xen-devel" >> Date: Wednesday, March 18, 2009, 10:48 AM >>=20 >> Thank you. It's done >> Boris >>=20 >> --- On Wed, 3/18/09, Stefano Stabellini >> wrote: >>> From: Stefano Stabellini >>> Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems >>> To: "bderzhavets@yahoo.com" >>> Cc: "xen-devel" >>> Date: Wednesday, March 18, 2009, 10:19 AM >>>=20 >>> Boris Derzhavets wrote: >>>=20 >>>> > Removed unresolved reference in >>>> > /usr/src/xen-unstable.hg/tools/ioemu-dir/vl.c:5898: undefined refere= nce >>>> > to `pci_emulation_add' >>>> >=20 >>>> > /* for (i =3D 0; i < nb_pci_emulation; i++) { >>>> > if(pci_emulation_add(pci_emulation_config_text[i]) < 0) >>> { >>>> > fprintf(stderr, "Warning: could not add PCI device >>> %s\n", >>>> > pci_emulation_config_text[i]); >>>> > } >>>> > } >>>> > */ >>>> >=20 >>>> > "make tools" completed OK. >>>> > Is it acceptable ? >>>> >=20 >>>=20 >>>=20 >>>=20 >>> I think we are missing an ifdef >>> CONFIG_PASSTHROUGH >>>=20 >>>=20 >>> diff --git a/vl.c b/vl.c >>> index 9b9f7d5..6c0ffb3 100644 >>> --- a/vl.c >>> +++ b/vl.c >>> @@ -5894,12 +5894,14 @@ int main(int argc, char **argv, char **envp) >>> } >>> } >>> =20 >>> +#ifdef CONFIG_PASSTHROUGH >>> for (i =3D 0; i < nb_pci_emulation; i++) { >>> if(pci_emulation_add(pci_emulation_config_text[i]) < 0) { >>> fprintf(stderr, "Warning: could not add PCI device >>> %s\n", >>> pci_emulation_config_text[i]); >>> } >>> } >>> +#endif >>> =20 >>> if (strlen(direct_pci_str) > 0) >>> direct_pci =3D >>> direct_pci_str; >>>=20 >>> _______________________________________________ >>> Xen-devel mailing list >>> Xen-devel@lists.xensource.com >>> http://lists.xensource.com/xen-devel >>=20 >> =20 >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel >=20 > =20 --B_3320233216_9787708 Content-type: text/html; charset="ISO-8859-1" Content-transfer-encoding: quoted-printable Re: [Xen-devel] [PATCH] fs-backend: fix compile problems Upgrade to latest xen-unstable. It’s fixed there.

 -- Keir

On 18/03/2009 14:53, "Boris Derzhavets" <bderzhavets@yahoo.com> wrote:

<= SPAN STYLE=3D'font-size:11pt'>Now "make install-xen" fails :-

make[6]: Entering directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu/mche= ck'
gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g -fno-st= rict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdecla= ration-after-statement  -nostdinc -fno-builtin -fno-common -iwithprefix= include -Werror -Wno-pointer-arith -pipe -I/usr/src/xen-unstable.hg/xen/inc= lude  -I/usr/src/xen-unstable.hg/xen/include/asm-x86/mach-generic -I/us= r/src/xen-unstable.hg/xen/include/asm-x86/mach-default -msoft-float -fno-sta= ck-protector -mno-red-zone -fpic -fno-reorder-blocks -fno-asynchronous-unwin= d-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -g -D__XEN__ -DVERBOSE -fno-omit-fra= me-pointer -DCONFIG_FRAME_POINTER -MMD -MF .mce_intel.o.d -c mce_intel.c -o = mce_intel.o
mce_intel.c:17: error: static declaration of ‘firstbank’ follow= s non-static declaration
x86_mca.h:95: error: previous declaration of ‘firstbank’ was he= re
make[6]: *** [mce_intel.o] Error 1
make[6]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu/mchec= k'
make[5]: *** [mcheck/built_in.o] Error 2
make[5]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu'
make[4]: *** [cpu/built_in.o] Error 2
make[4]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86'
make[3]: *** [/usr/src/xen-unstable.hg/xen/arch/x86/built_in.o] Error 2
make[3]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86'
make[2]: *** [/usr/src/xen-unstable.hg/xen/xen] Error 2
make[2]: Leaving directory `/usr/src/xen-unstable.hg/xen'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/usr/src/xen-unstable.hg/xen'
make: *** [install-xen] Error 2


--- On Wed, 3/18/09, Boris Derzhavets <bderzhavets@yahoo.com> wrote:
<= SPAN STYLE=3D'font-size:11pt'>From: Boris Derzhavets <bderzhavets@yahoo.com>
Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems
To: "Stefano Stabellini" <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel" <xen-d= evel@lists.xensource.com>
Date: Wednesday, March 18, 2009, 10:48 AM

Thank you. It's done
Boris

--- On Wed, 3/18/09, Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:
<= SPAN STYLE=3D'font-size:11pt'>From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems
To: "bderzhavets@yahoo.com" &= lt;bderzhavets@yahoo.com>
Cc: "xen-devel" <xen-d= evel@lists.xensource.com>
Date: Wednesday, March 18, 2009, 10:19 AM

Boris Derzhavets wrote:

> Removed unresolved reference in
> /usr/src/xen-unstable.hg/tools/ioemu-dir/vl.c:5898: undefined referenc= e
> to `pci_emulation_add'
>
> /*    for (i =3D 0; i < nb_pci_emulation; i++) {
>         if(pci_emulation_add(p= ci_emulation_config_text[i]) < 0)
 {
>            &nbs= p;fprintf(stderr, "Warning: could not add PCI device
%s\n",
>            &nbs= p;        pci_emulation_config_text[= i]);
>         }
>     }
> */
>
> "make tools" completed OK.
> Is it acceptable ?
>



I think we are missing an ifdef
 CONFIG_PASSTHROUGH


diff --git a/vl.c b/vl.c
index 9b9f7d5..6c0ffb3 100644
--- a/vl.c
+++ b/vl.c
@@ -5894,12 +5894,14 @@ int main(int argc, char **argv, char **envp)
         }
     }
 
+#ifdef CONFIG_PASSTHROUGH
     for (i =3D 0; i < nb_pci_emulation; i++) {          if(pci_emulation_add(= pci_emulation_config_text[i]) < 0) {
            &nb= sp;fprintf(stderr, "Warning: could not add PCI device
%s\n",
            &nb= sp;        pci_emulation_config_text= [i]);
         }
     }
+#endif
 
     if (strlen(direct_pci_str) > 0)
         direct_pci =3D
 direct_pci_str;

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com http://lists.xensource.com/x= en-devel
=
 
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com http://lists.xensource.com/x= en-devel
=
 
--B_3320233216_9787708-- --===============1040865828== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============1040865828==--