From: Keir Fraser Subject: Re: [PATCH] Fix domheap structure allocation when NUMA=on Date: Fri, 20 Mar 2009 08:56:18 +0000 Message-ID: References: <49C36646.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <49C36646.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , Xiaowei Yang Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 20/03/2009 08:47, "Jan Beulich" wrote: > virt_to_mfn(DIRECTMAP_VIRT_END - 1) is equal to > > Depending on whether DIRECTMAP_VIRT_END is the last byte or the first > following byte. Using "- 1" avoids such a dependency. > >> virt_to_mfn(DIRECTMAP_VIRT_END - PAGE_SIZE). Why +1? We use '<=' here. > > Because on the left side of the comparison we also calculate the first > following mfn, not the last included one. Since DIRECTMAP_VIRT_END is always the following byte not the last byte, it sounds like you think the page_alloc.c chunk is not needed at all. I'll just check in the header fix for now. -- Keir