From: Keir Fraser Subject: Re: [PATCH] Fix domheap structure allocation when NUMA=on Date: Fri, 20 Mar 2009 09:32:15 +0000 Message-ID: References: <49C36F81.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <49C36F81.76E4.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich , Xiaowei Yang Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 20/03/2009 09:27, "Jan Beulich" wrote: >> Since DIRECTMAP_VIRT_END is always the following byte not the last byte, it >> sounds like you think the page_alloc.c chunk is not needed at all. I'll just >> check in the header fix for now. > > No, that chunk is necessary afaics - as I said I agree to Xiaowei's diagnosis > that virt_to_mfn() should not be used on DIRECTMAP_VIRT_END alone. > Subtracting 1 from it, and then adding back 1 to the result is indeed what > I think is the right thing to do here. Ah... virt_to_mfn() has a discontinuity at DIRECTMAP_VIRT_END. I get you. I'll apply that chunk as a separate changeset then. -- Keir