From: Keir Fraser Subject: Re: [PATCH] Fix xenconsole after aborted save Date: Mon, 20 Apr 2009 15:41:17 +0100 Message-ID: References: <20090420140436.GB18963@orkuz.home> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090420140436.GB18963@orkuz.home> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jiri Denemark , Gerd Hoffmann Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 20/04/2009 15:04, "Jiri Denemark" wrote: >>> This patch modifies xenconsoled to check current status of open event >>> channels >>> and rebind them if necessary. >> >> close() + open() is the sledge hammer approach (will work though). Just >> unbind(local_port) should be enough. > > It doesn't close() and open(), it just calls xc_evtchn_bind_interdomain() in > case the event channel is unbound. The close() + open() combination was there > before... I haven't touched that code except for skipping it when only rebind > is required. And actually that is a bug, since you will leak the old dom->local_port. I checked in an alternative patch as c/s 19561, so please take a look and test that resolves your issue. Another thing to note is I think this problem can only occur if the domU does not support suspend cancellation (advertised as SUSPEND_CANCEL in kernel elf notes -- see xen/xend/XendDomainInfo.py:resumeDomain()). Your kernels should support that feature -- suspend cancellation (a.k.a. Resume) is very likely to be hit-or-miss without it! -- Keir