From: Keir Fraser Subject: Re: [PATCH 1 of 2] blkfront: sector size > 512 Date: Thu, 21 May 2009 06:32:30 -0700 Message-ID: References: <20090521132015.GU5806@const.famille.thibault.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090521132015.GU5806@const.famille.thibault.fr> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Samuel Thibault , Stefano Stabellini Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On 21/05/2009 06:20, "Samuel Thibault" wrote: >> Yeah, I am surprised as you are, but the linux blkfront does the same >> thing so I prefer to avoid changing the protocol now. > > Well, it's not about changing the protocol, it's about fixing drivers > doing the wrong thing according to the documentation. What is the use > of the xenstore sector_size value if not here? It's due to the protocol having evolved a bit. The xenstore sector_size was added a bit later, specifically after testing on CD-ROM drives, to require that frontends issue sector_size-aligned and -sized requests. Otherwise Linux blkdev subsystem was dropping the reqs on the floor. But we did not change the wire request format at that time. Yeah, I'd take a patch to add a nice clear comment about this to blkif.h. ;-) -- Keir