From: Keir Fraser Subject: Re: [PATCH] minios: replace mktime implementation Date: Wed, 27 May 2009 20:05:11 +0100 Message-ID: References: <3EE061F6-1589-4725-89CF-0780FA867F6F@nrg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <3EE061F6-1589-4725-89CF-0780FA867F6F@nrg.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Nigel Gamble , Stefano Stabellini Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On 27/05/2009 19:21, "Nigel Gamble" wrote: >> I checked and going back in time in 2003 entry.S in MiniOS has been >> rewritten to be able to license MiniOS under BSD, so we should be >> fine. > > Yes, it looks like this is true of x86_32.S, but it looks to me as if > x86_64.S was missed, because it is still clearly derived from Linux, > not BSD. Yes, you're quite obviously right. Stefano, we should at least remove all the commented out Linux code (most of which is CFI_* stack unwinding directives) and probably expand out many of the macros, most of which are used only once anyway. Plus rename/reorg where possible in line with x86_32.S. That's maybe an hour's work at most and I'd be comfortable claiming copyright on the result, or at least I'm certain it would be as clean as x86_32.S at that point (Which was never clean-room rewritten). -- Keir