From: Olof Johansson Date: Tue, 22 Sep 2009 15:12:05 -0500 Subject: [U-Boot] [PATCH] TI: OMAP3: Overo Tobi ethernet support In-Reply-To: <20090922195016.21245832E864@gemini.denx.de> References: <20090911204750.GA22246@lixom.net> <4AAB30DC.2000105@googlemail.com> <0554BEF07D437848AF01B9C9B5F0BC5D92708B0A@dlee01.ent.ti.com> <0554BEF07D437848AF01B9C9B5F0BC5D92708B58@dlee01.ent.ti.com> <20090922195016.21245832E864@gemini.denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sep 22, 2009, at 2:50 PM, Wolfgang Denk wrote: > Dear Ben Warren, > > In message > you wrote: >> >>> I always use 'git am -s', which adds the SOB. My understanding >>> is that >> maintainers should do this as an indication of approval and help in >> traceability. > > Please feel free to do that, but I consider this just adding > line-noise, unless you _really_ express special approval. > > Which sense would it make if I added a s-o-b to each and every commit > I'm pulling in from anywhere? You're not pulling it, you are applying it. And the s-o-b is used to show the paper trail of who has touched it. So all you should need to backtrack the source of the code change is the list of the s-o-bs. S-o-b is not an approval of the technical merits of the change. It's a pure bookkeeping measure to tell where a piece of code came from and who handled it on the way. BUT in addition to this it's really useful for a newbie like me to see who to send a patch to, since it shows the list of maintainership (up to the first person that submits his work through git pulls, but that seems nonexistent for non-maintainers in u-boot anyway :) -Olof