From: Keir Fraser Subject: Re: [PATCH] minios: minor buildsystem fixes Date: Wed, 15 Jul 2009 13:59:16 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Stefano Stabellini Cc: Samuel Thibault , Christoph Egger , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 15/07/2009 13:43, "Stefano Stabellini" wrote: >> If the distinction that Christoph's patch introduced *were* to be required, >> I would do it as XEN_COMPILE_OS and XEN_TARGET_OS replacing XEN_OS. Arguably >> it would be clearer to rename existing XEN_OS to the former anyway? >> > > I agree on that, XEN_OS as it is now is misleading. I changed my mind after all that. Obviously it is rather entrenched in tools/ right now that the compile OS is also the target OS. Renaming XEN_OS to one or the other gives the misleading impression we can cross-compile across operating systems, which we can't. I think your plan to leave XEN_OS alone and just define CONFIG_MiniOS -- and then hack makefiles a bit where necessary to explicitly take note of the latter -- makes most sense. -- Keir