From: Keir Fraser Subject: Re: [PATCH] passthru: Fix pci bar remapping for passthru devices Date: Mon, 20 Jul 2009 15:48:27 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Jiang, Yunhong" , Wei Wang2 , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Are you questioning whether this patch should be applied? -- Keir On 20/07/2009 15:26, "Jiang, Yunhong" wrote: > I assume guest should disable the MMIO in PCI_COMMAND before writing all = "1"s > to bar register. Otherwise, what will happen on native if guest try to ac= cess > 0xFFFFFFF0?=20 > And if we do update the P2M, will it cause trouble to Xen HV? >=20 > Thanks > Yunhong Jiang >=20 > xen-devel-bounces@lists.xensource.com wrote: >> Hi, >> When guest code tries to get the block size of mmio, it will write >> all "1"s into pci bar register and then qemu will return all "0"s to >> the don't care >> bits in the emulated bar register to indicate the block size >> to guest code. >> In this case, we should not create p2m mapping in >> pt_bar_reg_write() and >> pt_exp_rom_bar_reg_write(). Attached patch fixes this issue, >> additional comment can be found in the patch. >>=20 >> Thanks, >> Wei >>=20 >> Signed-off-by: Wei Wang >> -- >> AMD GmbH, Germany >> Operating System Research Center >>=20 >> Legal Information: >> Advanced Micro Devices GmbH >> Karl-Hammerschmidt-Str. 34 >> 85609 Dornach b. M=FCnchen >>=20 >> Gesch=E4ftsf=FChrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni >> Sitz: Dornach, Gemeinde Aschheim, Landkreis M=FCnchen >> Registergericht M=FCnchen, HRB Nr. 43632 > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel