From: Keir Fraser Subject: Re: [PATCH] xen: more robust serial port driver Date: Tue, 28 Jul 2009 15:15:42 +0100 Message-ID: References: <200907281607.06109.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200907281607.06109.Christoph.Egger@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christoph Egger , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 28/07/2009 15:07, "Christoph Egger" wrote: > > Attached patch adds a check if the fifo is usable before we > actually use it. I count that at least the first two chunks and the initialisation of tx_fifo_size are unnecessary. Might this be the case for the udelay(100) as well? And what kinds of systems have these broken UARTs that half-advertise a broken/non-existent FIFO? -- Keir