From: Keir Fraser Subject: Re: [PATCH] Add script to compile different versions of python; add python syntax checker Date: Wed, 29 Jul 2009 08:40:35 +0100 Message-ID: References: <4A6FD2C1.60906@flonatel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4A6FD2C1.60906@flonatel.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andreas Florath , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 29/07/2009 05:40, "Andreas Florath" wrote: > just recognised that the patch was applied - but the directory is now > different from the original. This breaks the Makefile and the provided > scripts. > > I'll send a patch against the current tip this evening. Ah, I just assumed it would all be relative to the directory it's resident in. Of course XEN_ROOT does need fixing (I forgot about that), but then you can make yourself a local-dir variable based directly on $(PWD) rather than $(XEN_ROOT). Also, at the same time it would be good if you would replace ${} make variable expansions with $(). It's purely a style consistency thing, as we use the latter in all other Makefiles. Thanks, Keir