From: Keir Fraser Subject: Re: [PATCH] xen: make (set|get)_xen_guest_handle available Date: Thu, 30 Jul 2009 11:14:04 +0100 Message-ID: References: <200907301112.15209.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200907301112.15209.Christoph.Egger@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christoph Egger , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 30/07/2009 10:12, "Christoph Egger" wrote: > Make (set|get)_xen_guest_handle() always available. > This avoids code snippets in the guest like this: > > #if __XEN_ITNERFACE_VERSION__ >= 0x00030201 > set_xen_guest_handle(hnd, val); > #else > hnd = val; > #endif Actually I don't see why you'd have code like this. *You*, the guest, gets to specify __XEN_INTERFACE_VERSION__ -- that is the point of it -- so ifdef'ing based on it in the guest is stupid. Just specify __XEN_INTERFACE_VERSION__ to be recent enough to have the guest handles, and then remove your ifdefs. Simple. -- Keir