From: Keir Fraser Subject: Re: [PATCH] xen: make (set|get)_xen_guest_handle available Date: Thu, 30 Jul 2009 14:24:33 +0100 Message-ID: References: <200907301234.38307.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200907301234.38307.Christoph.Egger@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christoph Egger Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 30/07/2009 11:34, "Christoph Egger" wrote: >> Actually I don't see why you'd have code like this. *You*, the guest, gets >> to specify __XEN_INTERFACE_VERSION__ -- that is the point of it -- so >> ifdef'ing based on it in the guest is stupid. >> >> Just specify __XEN_INTERFACE_VERSION__ to be recent enough to have the >> guest handles, and then remove your ifdefs. Simple. > > The point is to keep backward compatibility. The patch makes Xen more friendly > with using the old non-structured guest handler if the user wants. > > NetBSD offers both way to build & run it with either using the old or new > interface. This allows a smooth migration. Am I going to regret asking: Why? You only need to pick one API version (__XEN_INTERFACE_VERSION__) -- the resulting binaries will work with any Xen 3.x (since we guarantee ABI compatibility). -- Keir